Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2312523002: [turbofan] Readjust has_slot_use after splintering (Closed)

Created:
4 years, 3 months ago by Mircea Trofin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Readjust has_slot_use after splintering has_slot_use is computed early, and we need it to determine if we need to generate SpillRanges. After splintering, however, the information may be incorrect - e.g. just the splinter may have slot uses, and not the original. BUG= Committed: https://crrev.com/f1a6e5e79b3f402f3a3744c8fe431dfe18a0fd51 Cr-Commit-Position: refs/heads/master@{#39147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/compiler/live-range-separator.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
Small change that benefits consistency. In addition, it aids a CL where we'd avoid unnecessary ...
4 years, 3 months ago (2016-09-05 03:25:47 UTC) #7
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-05 04:03:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312523002/1
4 years, 3 months ago (2016-09-05 04:04:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 04:06:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 04:07:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1a6e5e79b3f402f3a3744c8fe431dfe18a0fd51
Cr-Commit-Position: refs/heads/master@{#39147}

Powered by Google App Engine
This is Rietveld 408576698