Issue 23125022: Merge 219111 "Start renderer in ContentViewCoreImpl::EvaluateJav..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23125022: Merge 219111 "Start renderer in ContentViewCoreImpl::EvaluateJav..." (Closed)

Created:
7 years, 4 months ago by joth

Modified:
7 years, 4 months ago

Reviewers:
michaelbai

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 219111 "Start renderer in ContentViewCoreImpl::EvaluateJav..." > Start renderer in ContentViewCoreImpl::EvaluateJavaScript. > > In WebView, the app could evaluate the Javascript before loading any page. This patch start renderer if there is no existing one. > > Since renderer was created without SiteInstance, the RenderViewCreated callback will not be called, this patch also call it even without SiteInstance. > > > > > BUG=273164 > > Review URL: https://chromiumcodereview.appspot.com/23018005 TBR=michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219351

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+53 lines, -10 lines)			Patch
android_webview/java/src/org/chromium/android_webview/AwContents.java	View	2 chunks	+8 lines, -1 line	0 comments	Download
content/browser/android/content_view_core_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/browser/android/content_view_core_impl.cc	View	2 chunks	+14 lines, -6 lines	0 comments	Download
content/browser/web_contents/web_contents_impl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	2 chunks	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r219351.

Expand Messages | Collapse Messages