Run VDA::Decode on GPU IO thread if VDA supports it.

content/common/gpu/media/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/android_video_decode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "content/common/gpu/gpu_channel.h"
@@ skipping 30 matching lines @@
 enum { kMaxBitstreamsNotifiedInAdvance = 32 };
 
 // static
 const base::TimeDelta AndroidVideoDecodeAccelerator::kDecodePollDelay =
     base::TimeDelta::FromMilliseconds(10);
 
 AndroidVideoDecodeAccelerator::AndroidVideoDecodeAccelerator(
     media::VideoDecodeAccelerator::Client* client,
     const base::WeakPtr<gpu::gles2::GLES2Decoder> decoder,
     const base::Callback<bool(void)>& make_context_current)
-    : client_(client),
+    : child_message_loop_(base::MessageLoop::current()),
+      client_(client),
       make_context_current_(make_context_current),
       codec_(media::kCodecH264),
       state_(NO_ERROR),
       surface_texture_id_(0),
       picturebuffers_requested_(false),
       io_task_is_posted_(false),
       decoder_met_eos_(false),
       num_bytes_used_in_the_pending_buffer_(0),
       gl_decoder_(decoder) {
 }
@@ skipping 260 matching lines @@
                          picture_buffer_texture_id, 0, size_.width(),
                          size_.height(), false, false, false);
 
   base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
       &AndroidVideoDecodeAccelerator::NotifyPictureReady,
       base::AsWeakPtr(this), media::Picture(picture_buffer_id, bitstream_id)));
 }
 
 void AndroidVideoDecodeAccelerator::Decode(
     const media::BitstreamBuffer& bitstream_buffer) {
+  if (!child_message_loop_->BelongsToCurrentThread) {

[Ami GONE FROM CHROMIUM, 2013/08/26 17:20:03]

Can you add a TODO to make this safe from the IO thread to each of the VDA impls
you added this shim to?

[piman, 2013/08/27 04:01:20]

You're missing the () to BelongsToCurrentThread().

[wuchengli, 2013/08/27 12:32:24]

This part of change has been reverted.

[wuchengli, 2013/08/27 12:32:24]

I added CanDecodeOnIOThread and this part of code has been reverted.

+    child_message_loop_->PostTask(
+        FROM_HERE,
+        base::Bind(&AndroidVideoDecodeAccelerator::Decode,
+                   base::AsWeakPtr(this),
+                   bitstream_buffer));
+    return;
+  }
+
   DCHECK(thread_checker_.CalledOnValidThread());
   if (bitstream_buffer.id() != -1 && bitstream_buffer.size() == 0) {
     base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
         &AndroidVideoDecodeAccelerator::NotifyEndOfBitstreamBuffer,
         base::AsWeakPtr(this), bitstream_buffer.id()));
     return;
   }
 
   pending_bitstream_buffers_.push(bitstream_buffer);
 
@@ skipping 123 matching lines @@
 void AndroidVideoDecodeAccelerator::NotifyResetDone() {
   client_->NotifyResetDone();
 }
 
 void AndroidVideoDecodeAccelerator::NotifyError(
     media::VideoDecodeAccelerator::Error error) {
   client_->NotifyError(error);
 }
 
 }  // namespace content