third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h - Issue 2312493002: [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

Issue 2312493002: [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (Closed)

Patch Set: fix buid /me shakes fist a GN files. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp ('K') | « third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp » ('j') | third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

index c77fd8fe5ecdcdd55ad5dedacdb75c5382f31b4a..cd7610a5526630e95948396c195fe2966be69efa 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

@@ -12,7 +12,7 @@

namespace blink {

class LocalFrame;

-class ThreadedWorkletGlobalScopeProxy;

+class ThreadedWorkletMessagingProxy;

class WorkletGlobalScopeProxy;

class MODULES_EXPORT AnimationWorklet final : public Worklet {

@@ -28,8 +28,7 @@ public:

private:

explicit AnimationWorklet(LocalFrame*);

- // TODO(ikilpatrick): this will change to a raw ptr once we have a thread.

- std::unique_ptr<ThreadedWorkletGlobalScopeProxy> m_workletGlobalScopeProxy;

+ ThreadedWorkletMessagingProxy* m_workletMessagingProxy;

yhirano 2016/09/12 09:02:59 Can you add comments describing why having this ra

};

} // namespace blink