Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231243002: PPAPI: Move some of NexeFileDidOpen to NexeLoadManager (Closed)

Created:
6 years, 8 months ago by dmichael (off chromium)
Modified:
6 years, 8 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

PPAPI: Move some of NexeFileDidOpen to NexeLoadManager This also tickled a bug in the generator because I named a variable with "http". Which made the generator tests run on presubmit. Which tickled a bug in the tests :-). So those are fixed here as an aside. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263073

Patch Set 1 #

Total comments: 1

Patch Set 2 : style fix #

Patch Set 3 : fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -59 lines) Patch
M components/nacl/renderer/nexe_load_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 2 3 chunks +86 lines, -0 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 5 chunks +24 lines, -9 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 2 chunks +12 lines, -1 line 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/generators/test_cgen_range/dev_channel_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/generators/test_cgen_range/versions.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/generators/test_cgen_range/versions.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +13 lines, -42 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmichael (off chromium)
6 years, 8 months ago (2014-04-09 16:52:22 UTC) #1
teravest
lgtm https://codereview.chromium.org/231243002/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/231243002/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode488 components/nacl/renderer/ppb_nacl_private_impl.cc:488: url); This indentation looks funny to me.
6 years, 8 months ago (2014-04-09 16:57:44 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-09 17:11:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/231243002/20001
6 years, 8 months ago (2014-04-09 17:12:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 18:22:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-09 18:22:50 UTC) #6
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-10 17:38:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/231243002/30001
6 years, 8 months ago (2014-04-10 17:38:54 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 20:59:35 UTC) #9
Message was sent while issue was closed. 
Change committed as 263073

Powered by Google App Engine
This is Rietveld 408576698