Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2312423003: MD Settings: Set overscroll before attempting to scroll to section (Closed)
Patch Set: keep setTimeout because timing sucks Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 27a07401995eb905a2e33c392078ebbdb7222b34..fe689f8fc18fcc978a72196cd2989f7b950673b7 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -188,7 +188,10 @@ Polymer({
}
}
- // Wait for any other changes prior to calculating the overflow padding.
+ // Calculate the overflow padding.
+ this.setOverscroll_(this.overscrollHeight_());
dschuyler 2016/09/08 21:00:37 I added some logging to see how often this call ha
+
+ // Wait for any other changes, then calculate the overflow padding again.
setTimeout(function() {
// Ensure any dom-if reflects the current properties.
Polymer.dom.flush();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698