Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2312413003: Remove isTerminating checks from fetch API + streams code (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
haraken, nhiroki
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isTerminating checks from fetch API + streams code BUG=641215 Committed: https://crrev.com/3912603d018537e6b260ede4f67c18e3957c9143 Cr-Commit-Position: refs/heads/master@{#416875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -98 lines) Patch
M third_party/WebKit/Source/core/streams/ReadableStreamController.h View 7 chunks +0 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 5 chunks +4 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 3 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
yhirano
4 years, 3 months ago (2016-09-07 06:23:33 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-09-07 06:24:29 UTC) #5
nhiroki
LGTM. Good luck! :)
4 years, 3 months ago (2016-09-07 06:28:53 UTC) #6
yhirano
let me try...
4 years, 3 months ago (2016-09-07 07:43:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312413003/1
4 years, 3 months ago (2016-09-07 07:43:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 07:48:00 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3912603d018537e6b260ede4f67c18e3957c9143 Cr-Commit-Position: refs/heads/master@{#416875}
4 years, 3 months ago (2016-09-07 07:50:17 UTC) #14
nhiroki
I just noticed isTerminating() still exists in ReadableStreamOperations.cpp.
4 years, 3 months ago (2016-09-08 13:00:04 UTC) #15
yhirano
4 years, 3 months ago (2016-09-08 23:50:42 UTC) #16
Message was sent while issue was closed.
On 2016/09/08 13:00:04, nhiroki wrote:
> I just noticed isTerminating() still exists in ReadableStreamOperations.cpp.

Ah, I see. I will remove it, too. Thank you.

Powered by Google App Engine
This is Rietveld 408576698