appengine/findit/waterfall/test/swarming_util_test.py - Issue 2312413002: [Findit] Record error if swarming task completes with exit_code as 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/swarming_util_test.py

Issue 2312413002: [Findit] Record error if swarming task completes with exit_code as 2. (Closed)

Patch Set: Add None check to avoid keyvalue error (related change) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/test/swarming_util_test.py

diff --git a/appengine/findit/waterfall/test/swarming_util_test.py b/appengine/findit/waterfall/test/swarming_util_test.py

index b4252b797ffbc13016c0a0cc4d1dfd98304bc1ae..9ac70162be055625c6fae6c7efc83247ef89c711 100644

--- a/appengine/findit/waterfall/test/swarming_util_test.py

+++ b/appengine/findit/waterfall/test/swarming_util_test.py

@@ -578,4 +578,8 @@ class SwarmingUtilTest(wf_testcase.WaterfallTestCase):

self.assertIsNone(swarming_util.GetTagValue(tags, 'c'))

def testGenerateIsolatedDataOutputsrefNone(self):

- self.assertEqual({}, swarming_util._GenerateIsolatedData(None))

+ self.assertEqual({}, swarming_util._GenerateIsolatedData(None))

+ def testFetchOutputJsonInfoFromIsolatedServerReturnNone(self):

+ self.assertIsNone(swarming_util._FetchOutputJsonInfoFromIsolatedServer(

+ None, self.http_client))