appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py - Issue 2312413002: [Findit] Record error if swarming task completes with exit_code as 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

Issue 2312413002: [Findit] Record error if swarming task completes with exit_code as 2. (Closed)

Patch Set: Add None check to avoid keyvalue error (related change) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py ('K') | « appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py ('k') | appengine/findit/waterfall/test/swarming_util_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

index aecef2b403d3a9637bf4f9b5d056b6d7afa0fb2a..3026c133da81221e2cd0f5a437ea159a40ddb53e 100644

--- a/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

+++ b/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

@@ -110,6 +110,7 @@ class ProcessSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

swarming_task_results = {

'task_id1': {

'state': 'COMPLETED',

+ 'exit_code': '1',

'tags': [

'priority:25',

'ref_name:abc_tests'