third_party/WebKit/Source/core/html/HTMLMetaElement.h - Issue 2312303002: Improve warnings for non-standard meta tag separators

Unified Diff: third_party/WebKit/Source/core/html/HTMLMetaElement.h

Issue 2312303002: Improve warnings for non-standard meta tag separators (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMetaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMetaElement.h b/third_party/WebKit/Source/core/html/HTMLMetaElement.h

index b82ae3b04afa0b0215e0eb6ad23f88745cf2e892..d3d79c651a9bdf9e154760f744c81bd9067a4019 100644

--- a/third_party/WebKit/Source/core/html/HTMLMetaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMetaElement.h

@@ -56,21 +56,21 @@ public:

private:

explicit HTMLMetaElement(Document&);

- static void processViewportKeyValuePair(Document*, const String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data);

+ static void processViewportKeyValuePair(Document*, bool& hasInvalidSeparator, const String& key, const String& value, bool viewportMetaZeroValuesQuirk, void* data);

bokan 2016/09/07 15:13:06 No need to pass any of these by reference. Just `b

static void parseContentAttribute(const String& content, void* data, Document*, bool viewportMetaZeroValuesQuirk);

void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

InsertionNotificationRequest insertedInto(ContainerNode*) override;

void didNotifySubtreeInsertionsToDocument() override;

- static float parsePositiveNumber(Document*, const String& key, const String& value, bool* ok = 0);

+ static float parsePositiveNumber(Document*, bool& hasInvalidSeparator, const String& key, const String& value, bool* ok = 0);

- static Length parseViewportValueAsLength(Document*, const String& key, const String& value);

- static float parseViewportValueAsZoom(Document*, const String& key, const String& value, bool& computedValueMatchesParsedValue, bool viewportMetaZeroValuesQuirk);

- static bool parseViewportValueAsUserZoom(Document*, const String& key, const String& value, bool& computedValueMatchesParsedValue);

- static float parseViewportValueAsDPI(Document*, const String& key, const String& value);

+ static Length parseViewportValueAsLength(Document*, bool& hasInvalidSeparator, const String& key, const String& value);

+ static float parseViewportValueAsZoom(Document*, bool& hasInvalidSeparator, const String& key, const String& value, bool& computedValueMatchesParsedValue, bool viewportMetaZeroValuesQuirk);

+ static bool parseViewportValueAsUserZoom(Document*, bool& hasInvalidSeparator, const String& key, const String& value, bool& computedValueMatchesParsedValue);

+ static float parseViewportValueAsDPI(Document*, bool& hasInvalidSeparator, const String& key, const String& value);

- static void reportViewportWarning(Document*, ViewportErrorCode, const String& replacement1, const String& replacement2);

+ static void reportViewportWarning(Document*, bool& hasInvalidSeparator, ViewportErrorCode, const String& replacement1, const String& replacement2);

void process();

void processViewportContentAttribute(const String& content, ViewportDescription::Type origin);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('J')