runtime/vm/flow_graph_type_propagator.cc - Issue 23123012: Fix crash in optimized code caused by missing IC data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 23123012: Fix crash in optimized code caused by missing IC data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

===================================================================

--- runtime/vm/flow_graph_type_propagator.cc (revision 26585)

+++ runtime/vm/flow_graph_type_propagator.cc (working copy)

@@ -491,8 +491,7 @@

intptr_t CompileType::ToNullableCid() {

if (cid_ == kIllegalCid) {

if (type_ == NULL) {

- // Type propagation is turned off.

- ASSERT(!FLAG_propagate_types);

+ // Type propagation is turned off or has not yet run.

return kDynamicCid;

} else if (type_->IsMalformed()) {

cid_ = kDynamicCid;

« no previous file with comments | « no previous file | runtime/vm/intrinsifier_arm.cc » ('j') | runtime/vm/intrinsifier_arm.cc » ('J')