Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: runtime/vm/intrinsifier_mips.cc

Issue 23123012: Fix crash in optimized code caused by missing IC data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1540 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 1551
1552 __ lw(T0, Address(SP, 0 * kWordSize)); 1552 __ lw(T0, Address(SP, 0 * kWordSize));
1553 __ lw(T0, FieldAddress(T0, String::length_offset())); 1553 __ lw(T0, FieldAddress(T0, String::length_offset()));
1554 1554
1555 __ beq(T0, ZR, &is_true); 1555 __ beq(T0, ZR, &is_true);
1556 __ LoadObject(V0, Bool::False()); 1556 __ LoadObject(V0, Bool::False());
1557 __ Ret(); 1557 __ Ret();
1558 __ Bind(&is_true); 1558 __ Bind(&is_true);
1559 __ LoadObject(V0, Bool::True()); 1559 __ LoadObject(V0, Bool::True());
1560 __ Ret(); 1560 __ Ret();
1561 return true; 1561 return false;
1562 } 1562 }
1563 1563
1564 1564
1565 bool Intrinsifier::OneByteString_getHashCode(Assembler* assembler) { 1565 bool Intrinsifier::OneByteString_getHashCode(Assembler* assembler) {
1566 Label no_hash; 1566 Label no_hash;
1567 1567
1568 __ lw(T1, Address(SP, 0 * kWordSize)); 1568 __ lw(T1, Address(SP, 0 * kWordSize));
1569 __ lw(V0, FieldAddress(T1, String::hash_offset())); 1569 __ lw(V0, FieldAddress(T1, String::hash_offset()));
1570 __ beq(V0, ZR, &no_hash); 1570 __ beq(V0, ZR, &no_hash);
1571 __ Ret(); // Return if already computed. 1571 __ Ret(); // Return if already computed.
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
1780 __ Bind(&ok); 1780 __ Bind(&ok);
1781 __ Ret(); 1781 __ Ret();
1782 1782
1783 __ Bind(&fall_through); 1783 __ Bind(&fall_through);
1784 return false; 1784 return false;
1785 } 1785 }
1786 1786
1787 } // namespace dart 1787 } // namespace dart
1788 1788
1789 #endif // defined TARGET_ARCH_MIPS 1789 #endif // defined TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698