Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h
index 0fdac8391ae45a11e5e3ec7443c7f80f6e909da9..e0aab95a33eecdba8a5f3c869cdab57ca37cee18 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h
@@ -23,6 +23,8 @@ public:
return create(length);
}
+ static CSSCalcLength* fromLength(const Length&);
+
#define GETTER_MACRO(name, type) \
double name(bool& isNull) \
{ \
@@ -53,11 +55,12 @@ public:
CSSValue* toCSSValue() const override;
StyleValueType type() const override { return CalcLengthType; }
+
protected:
- CSSLengthValue* addInternal(const CSSLengthValue* other) override;
- CSSLengthValue* subtractInternal(const CSSLengthValue* other) override;
- CSSLengthValue* multiplyInternal(double) override;
- CSSLengthValue* divideInternal(double) override;
+ CSSLengthValue* addInternal(const CSSLengthValue* other) override;
meade_UTC10 2016/09/27 04:41:39 Nit: no need for extra indent?
rjwright 2016/09/28 01:38:24 Done.
+ CSSLengthValue* subtractInternal(const CSSLengthValue* other) override;
+ CSSLengthValue* multiplyInternal(double) override;
+ CSSLengthValue* divideInternal(double) override;
private:
CSSCalcLength();

Powered by Google App Engine
This is Rietveld 408576698