Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)
Patch Set: Fixed unit test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
index a6d926984e95f9a86b18292980cf7babfde0e968..feff4a5c685ff2d9ecf28ecd00a343dc61d372a1 100644
--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
@@ -22,6 +22,7 @@ public:
}
CSSComputedStyleDeclaration* declaration() const { return m_declaration.get(); }
+ Node* pageNode() { return m_page->document().documentElement(); }
private:
std::unique_ptr<DummyPageHolder> m_page;
@@ -35,17 +36,17 @@ TEST_F(FilteredComputedStylePropertyMapTest, GetProperties)
Vector<AtomicString> customProperties({"--foo", "--bar"});
Vector<AtomicString> emptyCustomProperties;
- FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, customProperties);
+ FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, customProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("color"));
EXPECT_TRUE(map->getProperties().contains("align-items"));
EXPECT_TRUE(map->getProperties().contains("--foo"));
EXPECT_TRUE(map->getProperties().contains("--bar"));
- map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, emptyCustomProperties);
+ map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, emptyCustomProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("color"));
EXPECT_TRUE(map->getProperties().contains("align-items"));
- map = FilteredComputedStylePropertyMap::create(declaration(), emptyNativeProperties, customProperties);
+ map = FilteredComputedStylePropertyMap::create(declaration(), emptyNativeProperties, customProperties, pageNode());
EXPECT_TRUE(map->getProperties().contains("--foo"));
EXPECT_TRUE(map->getProperties().contains("--bar"));
}
@@ -54,7 +55,7 @@ TEST_F(FilteredComputedStylePropertyMapTest, NativePropertyAccessors)
{
Vector<CSSPropertyID> nativeProperties({CSSPropertyColor, CSSPropertyAlignItems});
Vector<AtomicString> emptyCustomProperties;
- FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, emptyCustomProperties);
+ FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), nativeProperties, emptyCustomProperties, pageNode());
TrackExceptionState exceptionState;
@@ -84,7 +85,7 @@ TEST_F(FilteredComputedStylePropertyMapTest, CustomPropertyAccessors)
{
Vector<CSSPropertyID> emptyNativeProperties;
Vector<AtomicString> customProperties({"--foo", "--bar"});
- FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), emptyNativeProperties, customProperties);
+ FilteredComputedStylePropertyMap* map = FilteredComputedStylePropertyMap::create(declaration(), emptyNativeProperties, customProperties, pageNode());
TrackExceptionState exceptionState;

Powered by Google App Engine
This is Rietveld 408576698