third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h - Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: Fixed unit test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h ('K') | « third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp » ('j') | third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h

diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h

index 83f6152999bdb9cf9bafb6b2362cb67f941a8387..15a3595c7a0e1ba3172b246a1906fe4681e936a7 100644

--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h

+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h

@@ -14,9 +14,9 @@ namespace blink {

class CORE_EXPORT FilteredComputedStylePropertyMap : public ComputedStylePropertyMap {

WTF_MAKE_NONCOPYABLE(FilteredComputedStylePropertyMap);

public:

- static FilteredComputedStylePropertyMap* create(CSSComputedStyleDeclaration* computedStyleDeclaration, const Vector<CSSPropertyID>& nativeProperties, const Vector<AtomicString>& customProperties)

+ static FilteredComputedStylePropertyMap* create(CSSComputedStyleDeclaration* computedStyleDeclaration, const Vector<CSSPropertyID>& nativeProperties, const Vector<AtomicString>& customProperties, Node* node)

{

- return new FilteredComputedStylePropertyMap(computedStyleDeclaration, nativeProperties, customProperties);

+ return new FilteredComputedStylePropertyMap(computedStyleDeclaration, nativeProperties, customProperties, node);

}

CSSStyleValue* get(const String& propertyName, ExceptionState&) override;

@@ -26,7 +26,7 @@ public:

Vector<String> getProperties() override;

private:

- FilteredComputedStylePropertyMap(CSSComputedStyleDeclaration*, const Vector<CSSPropertyID>& nativeProperties, const Vector<AtomicString>& customProperties);

+ FilteredComputedStylePropertyMap(CSSComputedStyleDeclaration*, const Vector<CSSPropertyID>& nativeProperties, const Vector<AtomicString>& customProperties, Node*);

HashSet<CSSPropertyID> m_nativeProperties;

HashSet<AtomicString> m_customProperties;