third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h - Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

Issue 2312293003: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: Fixed unit test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

index e4de0877c17aaf9cdf9e0f82349b624563e35230..5f6ef8ac911cd10d72ca124c3429423a275e63e3 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

@@ -27,10 +27,11 @@ public:

CSSValue* toCSSValue() const override;

-private:

+ // TODO: Renee: Move this back into private.

explicit CSSKeywordValue(const AtomicString& keyword)

meade_UTC10 2016/09/09 01:56:27 It's fine to create another create() method that o

: m_keywordValue(keyword) {}

+private:

AtomicString m_keywordValue;

};