Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2312273002: [worklets] Remove InProcessWorkerGlobalScopeProxy, and rename classes/methods. (Closed)

Created:
4 years, 3 months ago by ikilpatrick
Modified:
4 years, 3 months ago
Reviewers:
haraken, nhiroki, yhirano
CC:
chromium-reviews, falken, blink-worker-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, kinuko+worker_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[worklets] Remove InProcessWorkerGlobalScopeProxy, and rename classes/methods. As discussed in https://codereview.chromium.org/2310673002 removing the InProcessWorkerGlobalScopeProxy interface class entirely. Also renames a bunch of the methods/classes whose name came from GlobalScopeProxy. (s/GlobalScopeProxy/MessagingProxy). BUG=567358 Committed: https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e Cr-Commit-Position: refs/heads/master@{#416809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -373 lines) Patch
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h View 2 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/workers/InProcessWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worker.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
A + third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h View 1 chunk +15 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
ikilpatrick
As discussed in Messaging Proxy patch. +haraken for Source/web/ changes.
4 years, 3 months ago (2016-09-06 17:39:30 UTC) #4
nhiroki
LGTM!
4 years, 3 months ago (2016-09-06 22:03:54 UTC) #7
haraken
LGTM
4 years, 3 months ago (2016-09-06 23:41:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312273002/1
4 years, 3 months ago (2016-09-07 00:54:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 00:58:56 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e93df9b29bc879e26f5bdb72a52bc9bd5f63eb3e Cr-Commit-Position: refs/heads/master@{#416809}
4 years, 3 months ago (2016-09-07 01:00:19 UTC) #13
yhirano
4 years, 3 months ago (2016-09-07 01:00:50 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698