Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2312263003: Move some deprecated prefs out of chrome/common/pref_names.cc. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Jinsuk Kim
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some deprecated prefs out of chrome/common/pref_names.cc. Move them into chrome/browser/prefs/browser_prefs.cc and cleanup some nits there. Committed: https://crrev.com/f2a0fa9664e0b25a82a16e414e0fe4765ffcd2e9 Cr-Commit-Position: refs/heads/master@{#416890}

Patch Set 1 #

Patch Set 2 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 8 chunks +31 lines, -23 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Lei Zhang
4 years, 3 months ago (2016-09-07 06:45:37 UTC) #8
Jinsuk Kim
On 2016/09/07 06:45:37, Lei Zhang wrote: Much cleaner. lgtm. Thanks.
4 years, 3 months ago (2016-09-07 09:22:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312263003/20001
4 years, 3 months ago (2016-09-07 09:33:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 09:37:47 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 09:40:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2a0fa9664e0b25a82a16e414e0fe4765ffcd2e9
Cr-Commit-Position: refs/heads/master@{#416890}

Powered by Google App Engine
This is Rietveld 408576698