Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2312263002: [parser] Refactor of Parse*Statement*, part 2 (Closed)

Created:
4 years, 3 months ago by nickie
Modified:
4 years, 3 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Refactor of Parse*Statement*, part 2 This patch moves the following parsing methods to ParserBase: - ParseBlock R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/dfd03bbd2036660ad9a0be1c0a6f92f2e2075275 Cr-Commit-Position: refs/heads/master@{#39251}

Patch Set 1 : Just moving code (broken) #

Patch Set 2 : The real patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -49 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 chunks +31 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/parsing/preparser.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nickie
4 years, 3 months ago (2016-09-06 17:05:32 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-06 17:07:23 UTC) #2
nickie
I've uploaded this in two patch sets. The first just moves Parser::ParseBlock to ParserBase<Impl>::ParseBlock and ...
4 years, 3 months ago (2016-09-06 17:09:07 UTC) #3
adamk
patch lgtm now that I see the real patch :) and yes, I found this ...
4 years, 3 months ago (2016-09-06 17:10:55 UTC) #6
marja
lgtm Yes, this is easier to review; I'll also start using this method myself :)
4 years, 3 months ago (2016-09-07 10:44:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312263002/20001
4 years, 3 months ago (2016-09-07 13:29:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 13:31:51 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 13:32:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfd03bbd2036660ad9a0be1c0a6f92f2e2075275
Cr-Commit-Position: refs/heads/master@{#39251}

Powered by Google App Engine
This is Rietveld 408576698