chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java - Issue 2312253003: Add Field Trial factor to NewTabPageLayout calculations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2312253003: Add Field Trial factor to NewTabPageLayout calculations. (Closed)

Patch Set: Deduplicate field trial name. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

index dbef867f0550358e57b9c201de18c2168679e939..1f031d9006c0f63da19949b0624beff3085b4a50 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

@@ -240,6 +240,12 @@ public class NewTabPageRecyclerView extends RecyclerView {

return;

}

+ // If we have the card offset field trial enabled, don't peek at all.

+ if (CardsFieldTrial.getFirstCardOffsetDp() != 0) {

+ peekingCard.updatePeek(0, /* shouldAnimate */ false);

+ return;

+ }

// Here we consider that if the header is animating (is not completely expanded), the card

// should as well. In that case, the space below the header is what we have available.

boolean shouldAnimate = header.itemView.getHeight() < mMaxHeaderHeight;