Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2312243002: Avoid use-after-free if frame is deleted when stopping loading. (Closed)

Created:
4 years, 3 months ago by Charlie Reis
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Avoid use-after-free if frame is deleted when stopping loading. WebFrame::stopLoading can run onload event handlers, which have the ability to delete the frame. This means we must be careful when calling it from within RenderFrameImpl, or else the remainder of the function may try to access a deleted object. BUG=638166, 639689 TEST=See bug 638166 comment 11 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2307463003 Cr-Commit-Position: refs/heads/master@{#416082} (cherry picked from commit ba53b47ffb07652d639e68db92743dc9aea21e5c) Committed: https://chromium.googlesource.com/chromium/src/+/670a635d98f3f5674b87d75141bd17253f2f0a5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -5 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 3 chunks +61 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +21 lines, -3 lines 0 comments Download
A content/test/data/navigation_controller/remove_blank_iframe_on_load.html View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
Merging to M54.
4 years, 3 months ago (2016-09-06 16:14:13 UTC) #2
Charlie Reis
Committed patchset #1 (id:1) manually as 670a635d98f3f5674b87d75141bd17253f2f0a5c.
4 years, 3 months ago (2016-09-06 16:22:07 UTC) #4
dcheng
4 years, 3 months ago (2016-09-07 00:06:11 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698