src/sksl/SkSLSPIRVCodeGenerator.h - Issue 2312233002: refactored SkSL VarDeclaration handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/sksl/SkSLSPIRVCodeGenerator.h

Issue 2312233002: refactored SkSL VarDeclaration handling (Closed)

Patch Set: fixed nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/sksl/SkSLSPIRVCodeGenerator.h

diff --git a/src/sksl/SkSLSPIRVCodeGenerator.h b/src/sksl/SkSLSPIRVCodeGenerator.h

index caae20114d31f3e264339bfafa2b6ee78bfccafd..e7b2b30232add79630e6cc265cd1ee007581eddb 100644

--- a/src/sksl/SkSLSPIRVCodeGenerator.h

+++ b/src/sksl/SkSLSPIRVCodeGenerator.h

@@ -115,9 +115,9 @@ private:

SpvId writeFunction(const FunctionDefinition& f, std::ostream& out);

- void writeGlobalVars(const VarDeclaration& v, std::ostream& out);

+ void writeGlobalVars(const VarDeclarations& v, std::ostream& out);

- void writeVarDeclaration(const VarDeclaration& decl, std::ostream& out);

+ void writeVarDeclarations(const VarDeclarations& decl, std::ostream& out);

SpvId writeVariableReference(const VariableReference& ref, std::ostream& out);

« no previous file with comments | « src/sksl/SkSLParser.cpp ('k') | src/sksl/SkSLSPIRVCodeGenerator.cpp » ('j') | no next file with comments »