Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 231223002: Define SK_CPU_X86 on x86 machines. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
mtklein, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Define SK_CPU_X86 on x86 machines. Use this to only register flattening for SkSSE2ProcCoeffXfermode::CreateProc when it's linked. BUG=skia: TBR=reed@google.com NOTRY=true NOTREECHECKS=true Committed: http://code.google.com/p/skia/source/detail?r=14108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 8 months ago (2014-04-09 16:36:45 UTC) #1
mtklein
On 2014/04/09 16:36:45, mtklein wrote: Going to jam this in to fix the build.
6 years, 8 months ago (2014-04-09 16:47:48 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-09 16:47:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231223002/1
6 years, 8 months ago (2014-04-09 16:47:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 16:48:05 UTC) #5
commit-bot: I haz the power
Presubmit check for 231223002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-09 16:48:07 UTC) #6
bsalomon
lgtm
6 years, 8 months ago (2014-04-09 16:50:05 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-09 16:50:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231223002/1
6 years, 8 months ago (2014-04-09 16:50:43 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 16:51:04 UTC) #10
Message was sent while issue was closed.
Change committed as 14108

Powered by Google App Engine
This is Rietveld 408576698