Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2312223002: Add support for new dartium bots to archiver (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M tools/dartium/upload_steps.py View 5 chunks +21 lines, -21 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
4 years, 3 months ago (2016-09-06 14:51:39 UTC) #2
kustermann
lgtm https://codereview.chromium.org/2312223002/diff/1/tools/dartium/upload_steps.py File tools/dartium/upload_steps.py (right): https://codereview.chromium.org/2312223002/diff/1/tools/dartium/upload_steps.py#newcode64 tools/dartium/upload_steps.py:64: self.mode = 'Release' Why don't we have support ...
4 years, 3 months ago (2016-09-06 14:59:25 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 09e15a425ee6d9a2aaaa3df7ef51847991d37c90 (presubmit successful).
4 years, 3 months ago (2016-09-06 15:18:33 UTC) #5
Bill Hesse
4 years, 3 months ago (2016-09-06 15:32:55 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2312223002/diff/1/tools/dartium/upload_steps.py
File tools/dartium/upload_steps.py (right):

https://codereview.chromium.org/2312223002/diff/1/tools/dartium/upload_steps....
tools/dartium/upload_steps.py:64: self.mode = 'Release'
On 2016/09/06 14:59:25, kustermann wrote:
> Why don't we have support for release/debug?

Because we don't need it, we don't have debug bots (except on FYI, which we have
ignored for a year), and dartium will be phased out soon, and we can add support
for debug easily if we ever need it.

Powered by Google App Engine
This is Rietveld 408576698