Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: packages/web_components/lib/build/import_inliner.dart

Issue 2312183003: Removed Polymer from Observatory deps (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/web_components/lib/build/import_inliner.dart
diff --git a/packages/web_components/lib/build/import_inliner.dart b/packages/web_components/lib/build/import_inliner.dart
index 1f562a7459202f1e2bcf891a30f6b4ed83e0bae6..a603dda8f6fd9293b70727b6e173ff470b06fed1 100644
--- a/packages/web_components/lib/build/import_inliner.dart
+++ b/packages/web_components/lib/build/import_inliner.dart
@@ -38,7 +38,8 @@ class ImportInlinerTransformer extends Transformer {
apply(Transform transform) {
var logger = new BuildLogger(transform, convertErrorsToWarnings: true);
return new ImportInliner(transform, transform.primaryInput.id, logger,
- bindingStartDelimiters: bindingStartDelimiters).run();
+ bindingStartDelimiters: bindingStartDelimiters)
+ .run();
}
}
@@ -71,8 +72,10 @@ class ImportInliner {
if (imports.length > 1) {
_inlineImports(primaryDocument, imports);
} else if (!changed &&
- primaryDocument.querySelectorAll('link[rel="import"]').where(
- (import) => import.attributes['type'] != 'css').length ==
+ primaryDocument
+ .querySelectorAll('link[rel="import"]')
+ .where((import) => import.attributes['type'] != 'css')
+ .length ==
0) {
// If there were no url changes and no imports, then we are done.
return;
@@ -173,9 +176,6 @@ class _UrlNormalizer extends TreeVisitor {
/// Asset where the original content (and original url) was found.
final AssetId sourceId;
- /// Counter used to ensure that every library name we inject is unique.
- int _count = 0;
-
/// Path to the top level folder relative to the transform primaryInput.
/// This should just be some arbitrary # of ../'s.
final String topLevelPath;
@@ -303,7 +303,8 @@ class _UrlNormalizer extends TreeVisitor {
if (primaryInput.package != id.package) {
// Technically we shouldn't get there
- logger.error(internalErrorDontKnowHowToImport
+ logger.error(
+ internalErrorDontKnowHowToImport
.create({'target': id, 'source': primaryInput, 'extra': ''}),
span: span);
return href;

Powered by Google App Engine
This is Rietveld 408576698