MacViews: Fix flashing of opaque non-modal windows on display.

MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black
strip is displayed in the non web-contents area, when it is displayed initially.

Committed: https://crrev.com/f6ac68b04228683aa3176ad4020e109fbde5abf6
Cr-Commit-Position: refs/heads/master@{#417863}

[karandeepb, 2016-09-06 12:04:43]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-09-09 03:34:24]

Patchset #2 (id:20001) has been deleted

[karandeepb, 2016-09-09 03:34:31]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-09-09 03:44:44]

Description was changed from

==========
Task manager flash of gray.
==========

to

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

[karandeepb, 2016-09-09 04:08:52]

Description was changed from

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

to

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

[karandeepb, 2016-09-09 04:12:02]

karandeepb@chromium.org changed reviewers:
+ ccameron@chromium.org

[karandeepb, 2016-09-09 04:12:03]

PTAL ccameron@. Can you please review this since Trent is OOO.

[ccameron, 2016-09-11 20:43:18]

lgtm

[karandeepb, 2016-09-12 01:04:30]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-09-12 01:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 01:44:03]

Description was changed from

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

to

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

[commit-bot: I haz the power, 2016-09-12 01:44:05]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-09-12 01:46:09]

Description was changed from

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the 
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black 
strip is displayed in the non web-contents area, when it is displayed initially.
==========

to

==========
MacViews: Fix flashing of opaque non-modal windows on display.

Currently, opaque non-modal windows like the Task Manager appear with a "flash",
when displayed initially. This is because if the frame from the compositor
hasn't arrived yet, the background color of the window shows through. When the
frame arrives, the actual contents are displayed, causing a "flash".

To get around this, for opaque non-modal windows, set the alpha value of the
window to 0, till the correct frame from the compositor is received. Also,
ignore mouse clicks till then. This also fixes the "black strip" that is
displayed in the non webcontents area of the MacViewsBrowser, when it is
displayed initially.

BUG=623950, 645343
TEST=With chrome://flags/#mac-views-native-dialogs enabled, open the Task
Manager. Observe it is not displayed with a Flash. (Record a screencast and
observe frame by frame).
TEST=Build with mac_views_browser=true. Open the browser and observe no black
strip is displayed in the non web-contents area, when it is displayed initially.

Committed: https://crrev.com/f6ac68b04228683aa3176ad4020e109fbde5abf6
Cr-Commit-Position: refs/heads/master@{#417863}
==========

[commit-bot: I haz the power, 2016-09-12 01:46:10]

Patchset 1 (id:??) landed as
https://crrev.com/f6ac68b04228683aa3176ad4020e109fbde5abf6
Cr-Commit-Position: refs/heads/master@{#417863}