Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: chrome/browser/notifications/notification_ui_manager.cc

Issue 231213003: notification balloons: Remove views and cocoa implementations of BalloonCollection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager.cc
diff --git a/chrome/browser/notifications/notification_ui_manager.cc b/chrome/browser/notifications/notification_ui_manager.cc
index 84fe1aa8d1d5a8e1ef232a387d55448b6b68a160..c4e841f103ddc745a8dbf9b3613ace01686f1694 100644
--- a/chrome/browser/notifications/notification_ui_manager.cc
+++ b/chrome/browser/notifications/notification_ui_manager.cc
@@ -41,19 +41,13 @@ NotificationUIManager* NotificationUIManager::Create(PrefService* local_state) {
settings_provider.Pass());
}
-#if defined(OS_CHROMEOS)
- // Since we can't reach here for CrOS (see above), no point compiling all
- // the dependent classes there.
- CHECK(false);
- return NULL;
-#elif defined(OS_MACOSX) || defined(USE_AURA)
- // IsRichNotificationEnabled() always returns true in this case.
- CHECK(false);
- return NULL;
-#else
+#if defined(TOOLKIT_GTK)
BalloonNotificationUIManager* balloon_manager =
new BalloonNotificationUIManager(local_state);
balloon_manager->SetBalloonCollection(BalloonCollection::Create());
return balloon_manager;
+#else
+ CHECK(false);
+ return NULL;
#endif
}
« no previous file with comments | « chrome/browser/notifications/balloon_collection_impl.cc ('k') | chrome/browser/task_manager/task_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698