Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231213003: notification balloons: Remove views and cocoa implementations of BalloonCollection. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, dewittj
Visibility:
Public.

Description

notification balloons: Remove views and cocoa implementations of BalloonCollection. In both aura/views and mac, notifications are done through the message-center. So the implementations of BalloonCollection are never used. So remove these. Only the GTK version of the implementation remains. BUG=354062, 361784 R=mukai@chromium.org, rsesek@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262988

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2392 lines) Patch
D chrome/app/nibs/Notification.xib View 1 2 3 4 5 6 1 chunk +0 lines, -555 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.h View 1 2 3 4 5 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.cc View 1 2 3 4 5 9 chunks +1 line, -25 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_collection_cocoa.mm View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_controller.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 chunk +0 lines, -224 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view.mm View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view_bridge.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view_bridge.mm View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/views/notifications/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/views/notifications/balloon_collection_views.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/ui/views/notifications/balloon_view_host.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/views/notifications/balloon_view_views.h View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/ui/views/notifications/balloon_view_views.cc View 1 chunk +0 lines, -531 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 4 chunks +17 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +0 lines, -19 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sadrul
6 years, 8 months ago (2014-04-09 22:53:52 UTC) #1
Jun Mukai
lgtm if the tests pass.
6 years, 8 months ago (2014-04-09 22:57:29 UTC) #2
sadrul
The tests are passing! +sky@ for chrome/browser/extensions and chrome/browser/task_manager/ changes
6 years, 8 months ago (2014-04-10 00:49:11 UTC) #3
Jun Mukai
cc: dewittj just in case
6 years, 8 months ago (2014-04-10 00:51:21 UTC) #4
sky
LGTM
6 years, 8 months ago (2014-04-10 03:15:44 UTC) #5
sadrul
rsesek@ Do I have your blessings for removing the cocoa stuff? (I can remove that ...
6 years, 8 months ago (2014-04-10 12:01:26 UTC) #6
Robert Sesek
Please also remove chrome/app/nibs/Notification.xib.
6 years, 8 months ago (2014-04-10 13:24:14 UTC) #7
sadrul
On 2014/04/10 13:24:14, rsesek wrote: > Please also remove chrome/app/nibs/Notification.xib. Done.
6 years, 8 months ago (2014-04-10 13:39:23 UTC) #8
Robert Sesek
lgtm
6 years, 8 months ago (2014-04-10 13:40:04 UTC) #9
sadrul
6 years, 8 months ago (2014-04-10 14:41:43 UTC) #10
Message was sent while issue was closed. 
Committed patchset #7 manually as r262988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698