Move modal dialogs from WebViewClient to WebFrameClient, part 1.5/3.

Move modal dialogs from WebViewClient to WebFrameClient, part 1.5/3.

BUG=304341
TEST=modal dialogs still work
R=dmazzoni@chromium.org, nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262801

[Avi (use Gerrit), 2014-04-09 16:30:12]

Is this the right path? This seems to fix things locally...

[dmazzoni, 2014-04-09 16:42:34]

I'm not sure I have enough context to understand these changes. Perhaps nasko@
or creis@ or someone else working on OOPIF could review, and then I'm happy to
rubberstamp content/shell/renderer/test_runner

[Avi (use Gerrit), 2014-04-09 16:47:26]

Nasko, WDYT?

(BTW, the removal of lines in WebTestProxy are necessary so that they don't call
through to WebFrameTestProxy and double-print.)

[dmazzoni, 2014-04-09 17:00:19]

Do we still need WebTestProxyBase::runModalAlertDialog in WebTestProxy.cpp? I
don't quite understand why we need the logging in two places now.

[Avi (use Gerrit), 2014-04-09 17:14:39]

On 2014/04/09 17:00:19, dmazzoni wrote:
> Do we still need WebTestProxyBase::runModalAlertDialog in WebTestProxy.cpp? I
> don't quite understand why we need the logging in two places now.

Good point. New version is up.

[dmazzoni, 2014-04-09 17:19:38]

lgtm

Great, content/shell/renderer/test_runner is fine now but
I'd prefer to see a review from someone who understands the
broader context of oopif as well. Thanks.

[nasko, 2014-04-09 17:22:15]

I'm excited to see things start to disappear and duplication to be reduced!

LGTM

[Avi (use Gerrit), 2014-04-09 17:22:44]

On 2014/04/09 17:19:38, dmazzoni wrote:
> lgtm
> 
> Great, content/shell/renderer/test_runner is fine now but
> I'd prefer to see a review from someone who understands the
> broader context of oopif as well. Thanks.

BTW, the context is that we're moving stuff from WebViewClient to
WebFrameClient. This was preceeded by https://codereview.chromium.org/226503002
and the Blink change will be https://codereview.chromium.org/226413004/.

[Avi (use Gerrit), 2014-04-09 17:22:58]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-04-09 17:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/231213002/20001

[Avi (use Gerrit), 2014-04-09 20:41:07]

Committed patchset #2 manually as r262801 (presubmit successful).