Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2312123003: Revert of Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache. (patchset #4 id:60001 of https://codereview.chromium.org/2307053002/ ) Reason for revert: Causing assertions on bots Original issue's description: > Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache. > > Consolidates all flush actions into GrDrawingManager and makes GrContext::flush a passthrough. > > Removes the unused and untested discard flush variation. > > Replaces the indirect overbudget callback mechanism of GrResourceCache with a flag set by resource cache when it wants to flush that is checked after each draw by GrDrawContext. > > Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating whether it triggered the > flush that just occurred. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002 > > Committed: https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744 TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/5eb41fdf94187d6cc22702444622ed7897c8039a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -73 lines) Patch
M include/gpu/GrContext.h View 3 chunks +31 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +28 lines, -7 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawingManager.h View 4 chunks +3 lines, -14 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M src/gpu/GrResourceCache.h View 3 chunks +19 lines, -12 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 3 chunks +16 lines, -23 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
bsalomon
Created Revert of Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.
4 years, 3 months ago (2016-09-06 20:49:20 UTC) #2
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:51:04 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698