third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py - Issue 2312093003: Generated bindings for IDL callback functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

Issue 2312093003: Generated bindings for IDL callback functions (Closed)

Patch Set: Addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator_v8.py ('k') | third_party/WebKit/Source/bindings/scripts/idl_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

index ab824c72ed433a555329867e5a92c0877a9a33b4..00c1a285db88f0e26905c3fc7324af14214fa7a9 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

@@ -219,7 +219,12 @@ class InterfaceInfoCollector(object):

self.typedefs.update(definitions.typedefs)

for callback_function_name, callback_function in definitions.callback_functions.iteritems():

if 'ExperimentalCallbackFunction' in callback_function.extended_attributes:

- self.callback_functions[callback_function_name] = callback_function

+ # Set 'component_dir' to specify a directory that callback function files belong to

+ self.callback_functions[callback_function_name] = {

+ 'callback_function': callback_function,

+ 'component_dir': idl_filename_to_component(idl_filename),

+ 'full_path': os.path.realpath(idl_filename),

+ }

# Check enum duplication.

for enum_name in definitions.enumerations.keys():

for defined_enum in self.enumerations: