Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed win failure Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp ('k') | third_party/WebKit/Source/core/core_idl_files.gni » ('j') | third_party/WebKit/Source/core/testing/CallbackFunctionTest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 8e267baf0c98effc2ba652fc82d563a73eddc69c..9929d51c420efb56127dc706f180a379f020ee29 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -209,10 +209,12 @@ source_set("testing") {
":generated_testing_idls",
"//third_party/WebKit/Source/bindings/core/v8:testing",
]
-
+#maybe not correct
haraken 2016/09/20 07:08:22 Remove this.
lkawai 2016/09/20 08:15:06 Done.
sources = [
"$blink_core_output_dir/testing/InternalSettingsGenerated.cpp",
"$blink_core_output_dir/testing/InternalSettingsGenerated.h",
+ "testing/CallbackFunctionTest.cpp",
+ "testing/CallbackFunctionTest.h",
"testing/DictionaryTest.cpp",
"testing/DictionaryTest.h",
"testing/DummyPageHolder.cpp",
« third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp ('k') | third_party/WebKit/Source/core/core_idl_files.gni » ('j') | third_party/WebKit/Source/core/testing/CallbackFunctionTest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698