Generated bindings for IDL callback functions

third_party/WebKit/Source/bindings/scripts/utilities.py

Index: third_party/WebKit/Source/bindings/scripts/utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/utilities.py b/third_party/WebKit/Source/bindings/scripts/utilities.py
index 8d1caaad3fa39bf8a11980e9fde27639b8df30f9..a9871f6d5dbaadb36b42d32591fd62dcd173ce11 100644
--- a/third_party/WebKit/Source/bindings/scripts/utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/utilities.py
@@ -91,6 +91,10 @@ class ComponentInfoProvider(object):
     def include_path_for_union_types(self, union_type):
         return None
 
+    @property
+    def callback_functions(self):
+        return {}
+
 
 class ComponentInfoProviderCore(ComponentInfoProvider):
     def __init__(self, interfaces_info, component_info):
@@ -123,6 +127,10 @@ class ComponentInfoProviderCore(ComponentInfoProvider):
         return 'bindings/core/v8/%s.h' % name
 
     @property
+    def callback_functions(self):
+        return self._component_info['callback_functions']
+
+    @property
     def specifier_for_export(self):
         return 'CORE_EXPORT '
 
@@ -174,6 +182,11 @@ class ComponentInfoProviderModules(ComponentInfoProvider):
         return 'bindings/modules/v8/%s.h' % name
 
     @property
+    def callback_functions(self):
+        # TODO(lkawai): Make callback functions defined in core/ be usable in modules/.

[haraken, 2016/09/20 07:08:21]

I'm just curious but can't we fix the TODO just by returning
self._component_info_modules['callback_functions'] +
self._component_info['callback_functions'] ?

[bashi, 2016/09/20 07:42:57]

Sorry for lack of explanations. IIUC if we do that, we will create .cpp/.h under
both bindings/core/v8 and bindings/modules/v8 when a callback is defined in
core/.

Lisa-san, correct me if I'm wrong (I don't remember the exact reason).

[lkawai, 2016/09/20 08:15:06]

Acknowledged.

+        return self._component_info_modules['callback_functions']
+
+    @property
     def specifier_for_export(self):
         return 'MODULES_EXPORT '