Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
index f545643a67be9c28b73c3797b61944446da7572d..ec0f55fd86d2c6307a91e32be4791380c06b3c4a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
@@ -196,6 +196,15 @@ generated_core_testing_dictionary_files = [
"$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h",
]
+
+generated_core_testing_callback_function_files = [
+ "$bindings_core_v8_output_dir/V8TestCallback.cpp",
+ "$bindings_core_v8_output_dir/V8TestCallback.h",
+]
+
+#if (is_win && is_official_build) {
bashi 2016/09/16 05:51:18 Please remove this.
lkawai 2016/09/16 10:03:19 Done.
+# bindings_core_generated_aggregate_files =
peria 2016/09/16 05:48:18 Drop these comment-out lines
lkawai 2016/09/16 10:03:19 Done.
+
if (is_win) {
# On Windows Official release builds, we try to preserve symbol space.
bindings_core_generated_interface_files =
@@ -244,9 +253,10 @@ aggregate_generated_bindings("generate_bindings_core_v8_all_interfaces") {
idl_impl("bindings_core_impl_generated") {
sources = core_dictionary_idl_files + core_testing_dictionary_idl_files
- outputs =
- bindings_core_generated_union_type_files +
- generated_core_dictionary_files + generated_core_testing_dictionary_files
+ outputs = bindings_core_generated_union_type_files +
+ generated_core_dictionary_files +
+ generated_core_testing_dictionary_files +
+ generated_core_testing_callback_function_files
output_dir = bindings_core_v8_output_dir
target_component = "core"
}
@@ -266,7 +276,8 @@ blink_core_sources("bindings_core_impl") {
# as part of the "core" component so shouldn't use the blink_core_sources for
# linking on Windows.
source_set("testing") {
- sources = generated_core_testing_dictionary_files
+ sources = generated_core_testing_dictionary_files +
+ generated_core_testing_callback_function_files
configs -= core_config_remove
configs += [

Powered by Google App Engine
This is Rietveld 408576698