Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
index 6c1c3781a2ce24e8098865fc1ad837ef38396577..e2be6ffa826fee939ccdccf113138ff40674eb54 100644
--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
@@ -32,6 +32,7 @@ enum TestEnum {"", "EnumValue1", "EnumValue2", "EnumValue3"};
callback VoidCallbackFunction = void ();
callback AnyCallbackFunctionOptionalAnyArg = any (optional any optionalAnyArg);
+[ExperimentalCallbackFunction] callback VoidCallbackFunction2 = void ();
Yuki 2016/09/14 11:57:22 I'd recommend to have two types of callback functi
peria 2016/09/15 01:14:32 could you rename this type more descriptive? e.g.
lkawai 2016/09/16 05:05:50 Done.
lkawai 2016/09/16 05:05:50 Done.
lkawai 2016/09/16 05:05:50 Done.
// No extended attributes on the interface; those go in TestInterface.idl
interface TestObject {
@@ -323,6 +324,7 @@ interface TestObject {
void voidMethodOptionalVoidCallbackFunctionArg(optional VoidCallbackFunction voidCallbackFunctionArg);
void voidMethodNullableVoidCallbackFunctionArg(VoidCallbackFunction? voidCallbackFunctionArg);
void voidMethodAnyCallbackFunctionOptionalAnyArg(AnyCallbackFunctionOptionalAnyArg anyCallbackFunctionOptionalAnyArgArg);
+ void voidMethodVoidCallbackFunction2Arg(VoidCallbackFunction2 voidCallbackFunction2Arg);
peria 2016/09/15 01:14:32 ditto.
lkawai 2016/09/16 05:05:51 Done.
// Custom type conversions
any anyMethod();
void voidMethodEventTargetArg(EventTarget eventTargetArg);

Powered by Google App Engine
This is Rietveld 408576698