Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/bindings.gni") 5 import("//third_party/WebKit/Source/bindings/bindings.gni")
6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
7 import("//third_party/WebKit/Source/core/core.gni") 7 import("//third_party/WebKit/Source/core/core.gni")
8 import("//third_party/WebKit/Source/core/core_idl_files.gni") 8 import("//third_party/WebKit/Source/core/core_idl_files.gni")
9 9
10 visibility = [ "//third_party/WebKit/Source/*" ] 10 visibility = [ "//third_party/WebKit/Source/*" ]
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 189
190 generated_core_testing_dictionary_files = [ 190 generated_core_testing_dictionary_files = [
191 "$blink_core_output_dir/testing/InternalDictionary.cpp", 191 "$blink_core_output_dir/testing/InternalDictionary.cpp",
192 "$blink_core_output_dir/testing/InternalDictionary.h", 192 "$blink_core_output_dir/testing/InternalDictionary.h",
193 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp", 193 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp",
194 "$blink_core_output_dir/testing/InternalDictionaryDerived.h", 194 "$blink_core_output_dir/testing/InternalDictionaryDerived.h",
195 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp", 195 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp",
196 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h", 196 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h",
197 ] 197 ]
198 198
199 generated_core_testing_callback_function_files = [
200 "$bindings_core_v8_output_dir/V8TestCallback.cpp",
201 "$bindings_core_v8_output_dir/V8TestCallback.h",
202 ]
203
199 if (is_win) { 204 if (is_win) {
200 # On Windows Official release builds, we try to preserve symbol space. 205 # On Windows Official release builds, we try to preserve symbol space.
201 bindings_core_generated_interface_files = 206 bindings_core_generated_interface_files =
202 [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ] 207 [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ]
203 } else { 208 } else {
204 bindings_core_generated_interface_files = 209 bindings_core_generated_interface_files =
205 process_file_template( 210 process_file_template(
206 core_definition_idl_files, 211 core_definition_idl_files,
207 [ 212 [
208 "$bindings_core_v8_output_dir/V8{{source_name_part}}.cpp", 213 "$bindings_core_v8_output_dir/V8{{source_name_part}}.cpp",
(...skipping 28 matching lines...) Expand all
237 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp", 242 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp",
238 ] 243 ]
239 component = "core" 244 component = "core"
240 public_deps = [ 245 public_deps = [
241 ":generate_bindings_core_v8_interfaces", 246 ":generate_bindings_core_v8_interfaces",
242 ] 247 ]
243 } 248 }
244 249
245 idl_impl("bindings_core_impl_generated") { 250 idl_impl("bindings_core_impl_generated") {
246 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files 251 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files
247 outputs = 252 outputs = bindings_core_generated_union_type_files +
248 bindings_core_generated_union_type_files + 253 generated_core_dictionary_files +
249 generated_core_dictionary_files + generated_core_testing_dictionary_files 254 generated_core_testing_dictionary_files +
255 generated_core_testing_callback_function_files
250 output_dir = bindings_core_v8_output_dir 256 output_dir = bindings_core_v8_output_dir
251 target_component = "core" 257 target_component = "core"
252 } 258 }
253 259
254 # Compile the non-test sources generated above. 260 # Compile the non-test sources generated above.
255 blink_core_sources("bindings_core_impl") { 261 blink_core_sources("bindings_core_impl") {
256 sources = 262 sources =
257 bindings_core_generated_union_type_files + 263 bindings_core_generated_union_type_files +
258 generated_core_dictionary_files + bindings_core_generated_interface_files 264 generated_core_dictionary_files + bindings_core_generated_interface_files
259 265
260 deps = [ 266 deps = [
261 ":bindings_core_v8_generated", 267 ":bindings_core_v8_generated",
262 ] 268 ]
263 } 269 }
264 270
265 # Compile the test sources generated above. This test target doesn't count 271 # Compile the test sources generated above. This test target doesn't count
266 # as part of the "core" component so shouldn't use the blink_core_sources for 272 # as part of the "core" component so shouldn't use the blink_core_sources for
267 # linking on Windows. 273 # linking on Windows.
268 source_set("testing") { 274 source_set("testing") {
269 sources = generated_core_testing_dictionary_files 275 sources = generated_core_testing_dictionary_files +
276 generated_core_testing_callback_function_files
270 277
271 configs -= core_config_remove 278 configs -= core_config_remove
272 configs += [ 279 configs += [
273 "//third_party/WebKit/Source:inside_blink", 280 "//third_party/WebKit/Source:inside_blink",
274 "//third_party/WebKit/Source:config", 281 "//third_party/WebKit/Source:config",
275 ] 282 ]
276 283
277 deps = [ 284 deps = [
278 ":bindings_core_impl_generated", 285 ":bindings_core_impl_generated",
279 "//skia", 286 "//skia",
280 "//third_party/WebKit/Source/wtf", 287 "//third_party/WebKit/Source/wtf",
281 "//v8", 288 "//v8",
282 ] 289 ]
283 } 290 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698