Generated bindings for IDL callback functions

third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Generate template values for a callback function.
+
+Design doc: http://www.chromium.org/developers/design-documents/idl-compiler
+"""
+
+from v8_globals import includes
+import v8_utilities
+
+CALLBACK_FUNCTION_H_INCLUDES = frozenset([
+    'bindings/core/v8/ScopedPersistent.h',
+    'platform/heap/Handle.h',
+    'wtf/text/WTFString.h',
+])
+CALLBACK_FUNCTION_CPP_INCLUDES = frozenset([
+    'bindings/core/v8/ScriptState.h',
+    'bindings/core/v8/V8Binding.h',
+    'wtf/Assertions.h',
+])
+
+
+def callback_function_context(callback_function):
+    includes.clear()
+    includes.update(CALLBACK_FUNCTION_CPP_INCLUDES)
+    idl_type = callback_function.idl_type
+    idl_type_str = str(idl_type)
+    context = {
+        'cpp_class': callback_function.name,
+        'v8_class': v8_utilities.v8_class_name(callback_function),

[bashi, 2016/09/16 05:51:19]

nit: alphabetical order

[lkawai, 2016/09/16 10:03:19]

Done.

+        'header_includes': set(CALLBACK_FUNCTION_H_INCLUDES),
+        'cpp_includes': set(CALLBACK_FUNCTION_CPP_INCLUDES),
+        'return_cpp_type': idl_type.cpp_type + '&',
+        'idl_type': idl_type_str,
+        'return_cpp_value': idl_type.v8_value_to_local_cpp_value(

[peria, 2016/09/16 05:48:18]

This entry has not a value but a function, so I prefer to name the key more
descriptive like 'return_value_converter'.

[lkawai, 2016/09/16 10:03:19]

Done.

+            callback_function.extended_attributes, 'currentValue', 'cppValue', bailout_return_value="false"),
+    }
+    context.update(arguments_context(callback_function.arguments, context['return_cpp_type']))
+    return context
+
+
+def arguments_context(arguments, return_cpp_type):
+    def argument_context(argument):
+        return {
+            'handle_name': '%sHandle' % argument.name,

[bashi, 2016/09/16 05:51:19]

nit: alphabetical order

[lkawai, 2016/09/16 10:03:19]

Done.

+            'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
+                argument.name, isolate='scriptState->isolate()',
+                creation_context='scriptState->context()->Global()'),
+        }
+
+    argument_declarations = ['ScriptState* scriptState', 'ScriptWrappable* scriptWrappable']
+    argument_declarations.extend(
+        '%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
+        for argument in arguments)
+    if return_cpp_type != 'void':

[peria, 2016/09/16 05:48:18]

|return_cpp_type| has a suffix '&' as you defined on line #35,
so this condition must be always true.
You can find 'returnValue' in the argument of
V8VoidExperimentalCallbackFunction.

[lkawai, 2016/09/16 10:03:19]

Done.

+        argument_declarations.append('%s returnValue' % return_cpp_type)
+    return {
+        'argument_declarations': argument_declarations,
+        'arguments': [argument_context(argument) for argument in arguments],
+    }