third_party/WebKit/Source/core/testing/CallbackFunctionTest.idl - Issue 2312093003: Generated bindings for IDL callback functions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/CallbackFunctionTest.idl

Issue 2312093003: Generated bindings for IDL callback functions (Closed)

Patch Set: Addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	bashi 2016/09/13 00:35:07 s/2014/2016/ s/2014/2016/ lkawai 2016/09/16 05:05:52 Done. Show quoted text On 2016/09/13 00:35:07, bashi1 wrote: > s/2014/2016/ Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [ExperimentalCallbackFunction]callback TestCallback = DOMString (DOMString str1, DOMString str2);
	peria 2016/09/15 01:14:33 I'm not familiar with style guide of IDLs, but I t I'm not familiar with style guide of IDLs, but I think you need a space between options '[...]' and the keyword 'callback'. lkawai 2016/09/16 05:05:52 Done. Show quoted text On 2016/09/15 01:14:33, peria wrote: > I'm not familiar with style guide of IDLs, but I think you need a space > between options '[...]' and the keyword 'callback'. Done.
	6

	7 interface CallbackFunctionTest {

	8 [CallWith=ScriptState, RaisesException] DOMString testDOMString(TestCallback c allback);
	peria 2016/09/15 01:14:33 please rename this method to show what is tested i please rename this method to show what is tested in. (see Shiino-san's comment in idl-callback-function-unittest.html) lkawai 2016/09/16 05:05:52 Done. Show quoted text On 2016/09/15 01:14:33, peria wrote: > please rename this method to show what is tested in. > (see Shiino-san's comment in idl-callback-function-unittest.html) Done.
	9 };

OLD	NEW