Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp

Issue 2312093003: Generated bindings for IDL callback functions (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
bashi 2016/09/13 00:35:06 s/2014/2016/
lkawai 2016/09/16 05:05:51 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "core/testing/CallbackFunctionTest.h"
6
7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/V8Binding.h"
9 #include "bindings/core/v8/V8TestCallback.h"
10
11 namespace blink {
12
13 DEFINE_TRACE(CallbackFunctionTest)
14 {
15 }
16
17 String CallbackFunctionTest::testDOMString(ScriptState* scriptState, V8TestCallb ack* callback, ExceptionState& exceptionState)
18 {
19 String msg1 = "hello";
20 String msg2 = "world";
21 ScriptWrappable* scriptWrappable = nullptr;
22 String returnValue;
23
24 if (callback->call(scriptState, scriptWrappable, msg1, msg2, returnValue)) {
25 return String("SUCCESS: ") + returnValue; }
bashi 2016/09/13 00:35:07 Place '{' and '}' in a new line.
peria 2016/09/15 01:14:33 [style] Not correct. Keep '{' as-is. if (...) {
lkawai 2016/09/16 05:05:51 Done.
lkawai 2016/09/16 05:05:51 Done.
26 else { return String("Error!"); }
bashi 2016/09/13 00:35:06 Place '{' and '}' in a new line.
peria 2016/09/15 01:14:33 [style] In this case, you can remove 'else {' and
lkawai 2016/09/16 05:05:51 Done.
lkawai 2016/09/16 05:05:51 Done.
27 }
28
29 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698