third_party/WebKit/LayoutTests/fast/dom/idl-callback-function-unittest.html - Issue 2312093003: Generated bindings for IDL callback functions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/idl-callback-function-unittest.html

Issue 2312093003: Generated bindings for IDL callback functions (Closed)

Patch Set: Addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function() {

	6 var test = internals.callbackFunctionTest();
	bashi 2016/09/13 00:35:05 test -> callbackFunctionTest test -> callbackFunctionTest lkawai 2016/09/16 05:05:49 Done. Show quoted text On 2016/09/13 00:35:05, bashi1 wrote: > test -> callbackFunctionTest Done.
	7 var callback1 = function(msg1, msg2) {

	8 return msg1 + ', ' + msg2;

	9 };

	10 assert_equals(test.testDOMString(callback1), 'SUCCESS: hello, world');
	Yuki 2016/09/14 11:57:22 I'd recommend to make testDOMString take string ar I'd recommend to make testDOMString take string arguments so that you don't need to hard-code "hello" or "world". Also I'd recommend to rename this function because you're not testing DOMString, you're testing a callback function. lkawai 2016/09/16 05:05:49 Done. Show quoted text On 2016/09/14 11:57:22, Yuki wrote: > I'd recommend to make testDOMString take string arguments so that you don't need > to hard-code "hello" or "world". > > Also I'd recommend to rename this function because you're not testing DOMString, > you're testing a callback function. Done.
	11

	12 var callback2 = function(msg1, msg2) {

	13 return msg1 + msg1 + ' ' + msg2 + msg2;

	14 };

	15 assert_equals(test.testDOMString(callback2), 'SUCCESS: hellohello worldworld ');

	16 }, 'Callback function which takes two strings');

	17 </script>

OLD	NEW