Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2312093002: Reland of [gn] Switch win clang bot to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2311853002/ ) Reason for revert: Trying reland with plugin switched off. Original issue's description: > Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ ) > > Reason for revert: > Fails compilation: > https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang > > Original issue's description: > > [gn] Switch win clang bot to gn > > > > BUG=chromium:474921 > > NOTRY=true > > > > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 > > Cr-Commit-Position: refs/heads/master@{#39156} > > TBR=jochen@chromium.org,vogelheim@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e > Cr-Commit-Position: refs/heads/master@{#39158} TBR=jochen@chromium.org,vogelheim@chromium.org NOTRY=true BUG=chromium:474921, chromium:644096 Committed: https://crrev.com/70429e7a201ccec21fdc71dc62508a0f20b9261b Cr-Commit-Position: refs/heads/master@{#39201}

Patch Set 1 #

Patch Set 2 : Reland of [gn] Switch win clang bot to gn #

Patch Set 3 : Switch off clang plugins #

Patch Set 4 : TODO comment #

Patch Set 5 : Presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M infra/mb/mb_config.pyl View 1 2 3 4 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
Created Reland of [gn] Switch win clang bot to gn
4 years, 3 months ago (2016-09-06 08:58:41 UTC) #1
Michael Achenbach
PTAL. Trying reland with plugins switched off as Nico suggested. Left a TODO to switch ...
4 years, 3 months ago (2016-09-06 09:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312093002/80001
4 years, 3 months ago (2016-09-06 10:39:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23378)
4 years, 3 months ago (2016-09-06 10:42:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312093002/100001
4 years, 3 months ago (2016-09-06 11:15:05 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 3 months ago (2016-09-06 11:17:04 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 11:17:26 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/70429e7a201ccec21fdc71dc62508a0f20b9261b
Cr-Commit-Position: refs/heads/master@{#39201}

Powered by Google App Engine
This is Rietveld 408576698