Do not re-create the page view when accessing from Document::removeField.

Do not re-create the page view when accessing from Document::removeField.

When removing a field from the document we can force the recreation of a
CPDFSDK_PageView by passing |true| as the last parameter to |GetPageView|. This
will force a new page view to be created so we can delete a field from it and,
we then end up with a dangling PageView.

This CL passes |false| to |GetPageView| and skips removing the widget if we
do not receive a pageView back from the document.

BUG=chromium:644219
Committed: https://pdfium.googlesource.com/pdfium/+/1897bdc3cf51c84a0356d373e34ec100c93c954e

[dsinclair, 2016-09-06 19:05:27]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 19:05:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-06 19:22:56]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-09-06 19:22:56]

PTAL.

[commit-bot: I haz the power, 2016-09-06 19:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:25:26]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-06 20:45:45]

lgtm

Cross my fingers and hope nothing breaks.

https://codereview.chromium.org/2312023004/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2312023004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:504: // do not create one. We maybe in the
process of tearing down the document
s/maybe/may be/

[dsinclair, 2016-09-06 20:47:44]

https://codereview.chromium.org/2312023004/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2312023004/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:504: // do not create one. We maybe in the
process of tearing down the document
On 2016/09/06 20:45:45, Lei Zhang wrote:
> s/maybe/may be/

Done.

[dsinclair, 2016-09-06 20:47:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-06 20:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2312023004/#ps20001
(title: "review feedback")

[commit-bot: I haz the power, 2016-09-06 20:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:18:59]

Description was changed from

==========
Do not re-create the page view when accessing from Document::removeField.

When removing a field from the document we can force the recreation of a
CPDFSDK_PageView by passing |true| as the last parameter to |GetPageView|. This
will force a new page view to be created so we can delete a field from it and,
we then end up with a dangling PageView.

This CL passes |false| to |GetPageView| and skips removing the widget if we
do not receive a pageView back from the document.

BUG=chromium:644219
==========

to

==========
Do not re-create the page view when accessing from Document::removeField.

When removing a field from the document we can force the recreation of a
CPDFSDK_PageView by passing |true| as the last parameter to |GetPageView|. This
will force a new page view to be created so we can delete a field from it and,
we then end up with a dangling PageView.

This CL passes |false| to |GetPageView| and skips removing the widget if we
do not receive a pageView back from the document.

BUG=chromium:644219

Committed:
https://pdfium.googlesource.com/pdfium/+/1897bdc3cf51c84a0356d373e34ec100c93c...
==========

[commit-bot: I haz the power, 2016-09-06 21:19:00]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1897bdc3cf51c84a0356d373e34ec100c93c...