Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: trunk/tools/submit_try

Issue 23120002: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: apply_comments_from_patchset5 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/tools/submit_try
===================================================================
--- trunk/tools/submit_try (revision 10814)
+++ trunk/tools/submit_try (working copy)
@@ -21,16 +21,9 @@
import svn
import sys
+import buildbot_globals
-GLOBAL_VARIABLES = json.loads(svn.Cat('http://skia.googlecode.com/svn/'
- 'buildbot/site_config/'
- 'global_variables.json'))
-
-def GetGlobalVariable(var_name):
- return GLOBAL_VARIABLES[var_name]['value']
-
-
# Alias which can be used to run a try on every builder.
ALL_BUILDERS = 'all'
# Alias which can be used to run a try on all compile builders.
@@ -43,8 +36,8 @@
ALL_ALIASES = [ALL_BUILDERS, COMPILE_BUILDERS, CQ_BUILDERS, REGEX]
# Contact information for the build master.
-SKIA_BUILD_MASTER_HOST = str(GetGlobalVariable('master_host'))
-SKIA_BUILD_MASTER_PORT = str(GetGlobalVariable('external_port'))
+SKIA_BUILD_MASTER_HOST = str(buildbot_globals.Get('master_host'))
+SKIA_BUILD_MASTER_PORT = str(buildbot_globals.Get('external_port'))
# All try builders have this suffix.
TRYBOT_SUFFIX = '-Trybot'

Powered by Google App Engine
This is Rietveld 408576698