trunk/tools/buildbot_globals.py - Issue 23120002: Remove base-* directories from gm expected/actual paths; just use platform names

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: trunk/tools/buildbot_globals.py

Issue 23120002: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/

Patch Set: automatically_generate_builder_list Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:executable
+ *

OLD	NEW
(Empty)
	1 #!/usr/bin/python
	epoger 2013/08/16 20:16:26 Added buildbot_globals.py Added buildbot_globals.py
	2

	3 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 """

	8 Provides read access to buildbot's global_variables.json .

	9 """

	10

	11 import json

	12 import svn

	13

	14 _global_vars = None

	15

	16 def Get(var_name):

	17 '''Return the value associated with this name in global_variables.json. '''

	18 global _global_vars

	19 if not _global_vars:

	20 _global_vars = json.loads(svn.Cat('http://skia.googlecode.com/svn/'

	21 'buildbot/site_config/'

	22 'global_variables.json'))

	23 return _global_vars[var_name]['value']
	rmistry 2013/08/20 15:13:03 Optional: Catch KeyError and raise a better except Optional: Catch KeyError and raise a better exception, maybe something like NoSuchGlobalVariable. epoger 2013/08/20 15:46:19 Done. Show quoted text On 2013/08/20 15:13:03, rmistry wrote: > Optional: Catch KeyError and raise a better exception, maybe something like > NoSuchGlobalVariable. Done.
OLD	NEW

« no previous file with comments | « trunk/expectations/gm/base-shuttle_ubuntu12_ati5770/expected-results.json ('k') | trunk/tools/rebaseline.py » ('j') | trunk/tools/rebaseline.py » ('J')