Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: buildbot/slave/skia_slave_scripts/run_gm.py

Issue 23120002: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: apply_comments_from_patchset5 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ Run the Skia GM executable. """ 6 """ Run the Skia GM executable. """
7 7
8 from build_step import BuildStep 8 from build_step import BuildStep
9 import build_step 9 import build_step
10 import os 10 import os
11 import sys 11 import sys
12 12
13 13
14 JSON_SUMMARY_FILENAME = 'actual-results.json' 14 JSON_SUMMARY_FILENAME = 'actual-results.json'
15 15
16 16
17 class RunGM(BuildStep): 17 class RunGM(BuildStep):
18 def _Run(self): 18 def _Run(self):
19 device_gm_expectations_path = self._flavor_utils.DevicePathJoin( 19 device_gm_expectations_path = self._flavor_utils.DevicePathJoin(
20 self._device_dirs.GMExpectedDir(), build_step.GM_EXPECTATIONS_FILENAME) 20 self._device_dirs.GMExpectedDir(), build_step.GM_EXPECTATIONS_FILENAME)
21 output_dir = os.path.join(self._device_dirs.GMActualDir(), 21 output_dir = os.path.join(self._device_dirs.GMActualDir(),
22 self._gm_image_subdir) 22 self._builder_name)
23 cmd = ['--verbose', 23 cmd = ['--verbose',
24 '--writeChecksumBasedFilenames', 24 '--writeChecksumBasedFilenames',
25 # Don't bother writing out image files that match our expectations-- 25 # Don't bother writing out image files that match our expectations--
26 # we know that previous runs have already uploaded those! 26 # we know that previous runs have already uploaded those!
27 '--mismatchPath', output_dir, 27 '--mismatchPath', output_dir,
28 '--missingExpectationsPath', output_dir, 28 '--missingExpectationsPath', output_dir,
29 '--writeJsonSummaryPath', os.path.join(output_dir, 29 '--writeJsonSummaryPath', os.path.join(output_dir,
30 JSON_SUMMARY_FILENAME), 30 JSON_SUMMARY_FILENAME),
31 '--ignoreErrorTypes', 31 '--ignoreErrorTypes',
32 'IntentionallySkipped', 'MissingExpectations', 32 'IntentionallySkipped', 'MissingExpectations',
(...skipping 10 matching lines...) Expand all
43 'GalaxyNexus' in self._builder_name): 43 'GalaxyNexus' in self._builder_name):
44 cmd.extend(['--config', 'defaults', 'msaa4']) 44 cmd.extend(['--config', 'defaults', 'msaa4'])
45 elif (not 'NoGPU' in self._builder_name and 45 elif (not 'NoGPU' in self._builder_name and
46 not 'ChromeOS' in self._builder_name): 46 not 'ChromeOS' in self._builder_name):
47 cmd.extend(['--config', 'defaults', 'msaa16']) 47 cmd.extend(['--config', 'defaults', 'msaa16'])
48 self._flavor_utils.RunFlavoredCmd('gm', cmd) 48 self._flavor_utils.RunFlavoredCmd('gm', cmd)
49 49
50 50
51 if '__main__' == __name__: 51 if '__main__' == __name__:
52 sys.exit(BuildStep.RunBuildStep(RunGM)) 52 sys.exit(BuildStep.RunBuildStep(RunGM))
OLDNEW
« no previous file with comments | « buildbot/slave/skia_slave_scripts/prerender.py ('k') | buildbot/slave/skia_slave_scripts/upload_gm_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698