Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: src/heap/gc-tracer.cc

Issue 2311983002: Revert of [RuntimeCallStats] Move tracing runtime instrumentation closer to the original version. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-tracer.cc
diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc
index 98be41d3693be9e79c2faf20e077f7d13093668f..bbdbf7fb304900e49f5c604c98c56b2ab15dc0f7 100644
--- a/src/heap/gc-tracer.cc
+++ b/src/heap/gc-tracer.cc
@@ -26,11 +26,9 @@
start_time_ = tracer_->heap_->MonotonicallyIncreasingTimeInMs();
// TODO(cbruni): remove once we fully moved to a trace-based system.
if (FLAG_runtime_call_stats) {
- RuntimeCallStats::Enter(
- tracer_->heap_->isolate()->counters()->runtime_call_stats(), &timer_,
- &RuntimeCallStats::GC);
- }
- // TODO(lpy): Add a tracing equivalent for the runtime call stats.
+ RuntimeCallStats::Enter(tracer_->heap_->isolate(), &timer_,
+ &RuntimeCallStats::GC);
+ }
}
GCTracer::Scope::~Scope() {
@@ -38,10 +36,8 @@
scope_, tracer_->heap_->MonotonicallyIncreasingTimeInMs() - start_time_);
// TODO(cbruni): remove once we fully moved to a trace-based system.
if (FLAG_runtime_call_stats) {
- RuntimeCallStats::Leave(
- tracer_->heap_->isolate()->counters()->runtime_call_stats(), &timer_);
- }
- // TODO(lpy): Add a tracing equivalent for the runtime call stats.
+ RuntimeCallStats::Leave(tracer_->heap_->isolate(), &timer_);
+ }
}
const char* GCTracer::Scope::Name(ScopeId id) {
@@ -210,10 +206,8 @@
start_time, used_memory);
// TODO(cbruni): remove once we fully moved to a trace-based system.
if (FLAG_runtime_call_stats) {
- RuntimeCallStats::Enter(heap_->isolate()->counters()->runtime_call_stats(),
- &timer_, &RuntimeCallStats::GC);
- }
- // TODO(lpy): Add a tracing equivalent for the runtime call stats.
+ RuntimeCallStats::Enter(heap_->isolate(), &timer_, &RuntimeCallStats::GC);
+ }
}
void GCTracer::MergeBaseline(const Event& baseline) {
@@ -316,10 +310,8 @@
// TODO(cbruni): remove once we fully moved to a trace-based system.
if (FLAG_runtime_call_stats) {
- RuntimeCallStats::Leave(heap_->isolate()->counters()->runtime_call_stats(),
- &timer_);
- }
- // TODO(lpy): Add a tracing equivalent for the runtime call stats.
+ RuntimeCallStats::Leave(heap_->isolate(), &timer_);
+ }
}
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698