Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231193003: Add Create Shortcuts button to App Info dialog (Closed)

Created:
6 years, 8 months ago by sashab
Modified:
6 years, 8 months ago
Reviewers:
benwells, Matt Giuca
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add Create Shortcuts button to App Info dialog Add a button to the App Info dialog that launches the Create Shortcuts dialog. BUG=266739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264355

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added correct behaviour for ChromeOS #

Total comments: 3

Patch Set 3 : As small as a patch can be! Almost. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc View 1 2 5 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sashab
6 years, 8 months ago (2014-04-09 16:52:32 UTC) #1
benwells
https://codereview.chromium.org/231193003/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc (right): https://codereview.chromium.org/231193003/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc#newcode440 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc:440: // shortcuts? On ChromeOS you can't create shortcuts. You ...
6 years, 8 months ago (2014-04-09 17:02:20 UTC) #2
sashab
https://codereview.chromium.org/231193003/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc (right): https://codereview.chromium.org/231193003/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc#newcode440 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc:440: // shortcuts? On 2014/04/09 17:02:20, benwells wrote: > On ...
6 years, 8 months ago (2014-04-16 03:40:38 UTC) #3
Matt Giuca
lgtm https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h (right): https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h#newcode89 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h:89: // Create Shortcuts for the app. Must only ...
6 years, 8 months ago (2014-04-16 04:14:02 UTC) #4
benwells
lgtm with the nit fixed. https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc (right): https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc#newcode439 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc:439: // ChromeOS can be ...
6 years, 8 months ago (2014-04-16 04:38:44 UTC) #5
sashab
https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc (right): https://codereview.chromium.org/231193003/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc#newcode439 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc:439: // ChromeOS can be pin apps to the app ...
6 years, 8 months ago (2014-04-16 05:27:26 UTC) #6
sashab
The CQ bit was checked by sashab@chromium.org
6 years, 8 months ago (2014-04-16 05:27:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sashab@chromium.org/231193003/40001
6 years, 8 months ago (2014-04-16 05:28:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 07:22:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-16 07:22:01 UTC) #10
sashab
The CQ bit was checked by sashab@chromium.org
6 years, 8 months ago (2014-04-16 23:16:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sashab@chromium.org/231193003/40001
6 years, 8 months ago (2014-04-16 23:17:59 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 23:56:33 UTC) #13
Message was sent while issue was closed. 
Change committed as 264355

Powered by Google App Engine
This is Rietveld 408576698