Move ParseHoistableDeclaration to ParserBase.

Move ParseHoistableDeclaration to ParserBase.

BUG=

Committed: https://crrev.com/751f8e99c9e162faaebd4bd1b35ef6f015b54a98
Cr-Commit-Position: refs/heads/master@{#39300}

[marja, 2016-09-06 12:17:27]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 12:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:18:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12207)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8288)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23395)

[marja, 2016-09-06 12:50:11]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:50:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-09-06 12:51:10]

marja@chromium.org changed reviewers:
+ nikolaos@chromium.org

[marja, 2016-09-06 12:51:11]

nikolaos@, ptal

adamk@, fyi

(This CL is based on https://codereview.chromium.org/2301183003/ (not yet
landed), if the try jobs go red it's probably because of the rebase... I hope.
But at least the diff should make sense now for review.)

[commit-bot: I haz the power, 2016-09-06 13:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 13:16:16]

Dry run: This issue passed the CQ dry run.

[nickie, 2016-09-06 17:29:57]

LGTM, with two minor comments.

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/parser.h#ne...
src/parsing/parser.h:863: V8_INLINE static Statement* GetEmptyStatement() {
return nullptr; }
There's a NullStatement on line 881.  I suppose that's what you want.

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/preparser.h
File src/parsing/preparser.h (right):

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/preparser.h...
src/parsing/preparser.h:1052: V8_INLINE static PreParserStatement
GetEmptyStatement() {
Again, there's NullStatement in line 1076.

[marja, 2016-09-08 11:15:58]

Thanks for review!

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/parser.h#ne...
src/parsing/parser.h:863: V8_INLINE static Statement* GetEmptyStatement() {
return nullptr; }
On 2016/09/06 17:29:57, nickie wrote:
> There's a NullStatement on line 881.  I suppose that's what you want.

Ah true; confused about Null / Empty!

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/preparser.h
File src/parsing/preparser.h (right):

https://codereview.chromium.org/2311903003/diff/40001/src/parsing/preparser.h...
src/parsing/preparser.h:1052: V8_INLINE static PreParserStatement
GetEmptyStatement() {
On 2016/09/06 17:29:57, nickie wrote:
> Again, there's NullStatement in line 1076.

Done.

[marja, 2016-09-08 11:16:13]

The CQ bit was checked by marja@chromium.org

[marja, 2016-09-08 11:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org
Link to the patchset: https://codereview.chromium.org/2311903003/#ps80001
(title: "code review (nikolaos@)")

[commit-bot: I haz the power, 2016-09-08 11:16:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 11:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 11:17:29]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12372)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[marja, 2016-09-09 07:34:32]

The CQ bit was checked by marja@chromium.org

[marja, 2016-09-09 07:34:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org
Link to the patchset: https://codereview.chromium.org/2311903003/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-09 07:34:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 07:58:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-09 07:58:55]

Description was changed from

==========
Move ParseHoistableDeclaration to ParserBase.

BUG=
==========

to

==========
Move ParseHoistableDeclaration to ParserBase.

BUG=

Committed: https://crrev.com/751f8e99c9e162faaebd4bd1b35ef6f015b54a98
Cr-Commit-Position: refs/heads/master@{#39300}
==========

[commit-bot: I haz the power, 2016-09-09 07:58:56]

Patchset 6 (id:??) landed as
https://crrev.com/751f8e99c9e162faaebd4bd1b35ef6f015b54a98
Cr-Commit-Position: refs/heads/master@{#39300}