Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2311903002: [turbofan] Don't propagate truncations if output is tagged. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-644048.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc
index f0d90f653b9de1a96837eb50c6c67adfcea51812..0bb8a1ce2585fb1454485f152a4536296773c770 100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -912,6 +912,9 @@ class RepresentationSelector {
}
// Convert inputs to the output representation of this phi, pass the
// truncation truncation along.
+ if (output == MachineRepresentation::kTagged) {
+ truncation = Truncation::Any();
+ }
UseInfo input_use(output, truncation);
ProcessInput(node, 1, input_use);
ProcessInput(node, 2, input_use);
@@ -936,6 +939,9 @@ class RepresentationSelector {
// Convert inputs to the output representation of this phi, pass the
// truncation along.
+ if (output == MachineRepresentation::kTagged) {
+ truncation = Truncation::Any();
+ }
UseInfo input_use(output, truncation);
for (int i = 0; i < node->InputCount(); i++) {
ProcessInput(node, i, i < values ? input_use : UseInfo::None());
@@ -2415,6 +2421,9 @@ class RepresentationSelector {
MachineRepresentation output =
GetOutputInfoForPhi(node, TypeOf(node->InputAt(0)), truncation);
+ if (output == MachineRepresentation::kTagged) {
+ truncation = Truncation::Any();
+ }
VisitUnop(node, UseInfo(output, truncation), output);
if (lower()) DeferReplacement(node, node->InputAt(0));
return;
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-644048.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698