Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2311883002: Revert of [regexp] Port RegExpCompile and RegExpToString (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port RegExpCompile and RegExpToString (patchset #3 id:40001 of https://codereview.chromium.org/2295273003/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Port RegExpCompile and RegExpToString > > BUG=v8:5339 > > Committed: https://crrev.com/836299aa9c484eb96b6b4aa48270ab2c30b85801 > Cr-Commit-Position: refs/heads/master@{#39119} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Committed: https://crrev.com/7e7557507672bfc45ec57e1050fe478b6e734469 Cr-Commit-Position: refs/heads/master@{#39170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -75 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 2 chunks +0 lines, -67 lines 0 comments Download
M src/js/regexp.js View 3 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of [regexp] Port RegExpCompile and RegExpToString
4 years, 3 months ago (2016-09-05 12:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311883002/1
4 years, 3 months ago (2016-09-05 12:32:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 13:08:31 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 13:08:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e7557507672bfc45ec57e1050fe478b6e734469
Cr-Commit-Position: refs/heads/master@{#39170}

Powered by Google App Engine
This is Rietveld 408576698